Update Dependencies for Enhanced Compatibility with Newer Python Versions #5
Conversation
| mkdir -p banded_matrices/build | ||
| cd banded_matrices/build | ||
| cmake .. -DCMAKE_BUILD_TYPE=Release |
There was a problem hiding this comment.
I would be tempted to use the -B option of cmake: https://cmake.org/cmake/help/latest/manual/cmake.1.html#generate-a-project-buildsystem
| - name: Configure environment variables for CMake | ||
| run: | | ||
| echo "PYTHON_BIN=$(which python)" >> $GITHUB_ENV |
There was a problem hiding this comment.
It might be better to define the environment variable in a build step specifically: https://docs.github.com/en/actions/learn-github-actions/variables#defining-environment-variables-for-a-single-workflow
There was a problem hiding this comment.
not sure what you mean here!
There was a problem hiding this comment.
Rather than having a separate step to define a new environment variable and piping it into the global environment, the link describes how to add an env statement to the step in the github action definition for defining contextual environment variables.
This reverts commit ccd3c82.
vincentadam87
force-pushed
the
va/update-bm
branch
from
b960410
to
0ef525e
Compare
|
Regarding the workflow, I have a question |
vincentadam87
changed the title
Configuration changes in
pyproject.toml">=3.18.0,<3.19.0"from"~3.18.0"">=4.4,<5.0"from"importlib_metadata", "^1.6"">=1.18.0,<2.0.0"from"^1.18.0"">=3.7,<3.12"from"~3.7"">=2.4.0,<2.7.0"">=2.5.0,<2.7.0"">=2.7.0,<2.9.0"">=2.8.0,<2.16.0"">=1.1.0,<1.3.0"">=1.1.0,<1.3.0"">=1.1.0,<1.3.0""1.8.0""6.2.5"from"^5.3.5"">=0.3.8"from"^0.3.8"Gihub workflows changes